Skip to content

CSSTUDIO-3605 Always use the type "long" when converting to hexadecimal notation #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abrahamwolk wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CSSTUDIO-3605 Always use the type "long" when converting to hexadecimal notation #3674

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a190d29
CSSTUDIO-3605 Always use the type "long" when converting to hexadecim…
abrahamwolk Dec 12, 2025
fb37c8c
CSSTUDIO-3605 Bugfix: Avoid sign extension when converting numbers to…
abrahamwolk Dec 15, 2025
82cebbd
CSSTUDIO-3605 Add test cases.
abrahamwolk Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions core/ui/src/main/java/org/phoebus/ui/vtype/FormatOptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,9 @@ private static String formatNumber(final Number value, final Display display,
if (option == FormatOption.HEX)
{
final StringBuilder buf = new StringBuilder();
if (precision <= 8)
buf.append(Integer.toHexString(value.intValue()).toUpperCase());
else
buf.append(Long.toHexString(value.longValue()).toUpperCase());
long longValue = value.longValue();
String hexString = Long.toHexString(longValue);
buf.append(hexString.toUpperCase());
for (int i=buf.length(); i<precision; ++i)
buf.insert(0, '0');
buf.insert(0, "0x");
Expand Down