Fix: "Configure" proxmox log spam and password update timeout on VM creation#149
Open
ShiSHcat wants to merge 3 commits intoConvoyPanel:developfrom
Open
Fix: "Configure" proxmox log spam and password update timeout on VM creation#149ShiSHcat wants to merge 3 commits intoConvoyPanel:developfrom
ShiSHcat wants to merge 3 commits intoConvoyPanel:developfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The purpose of this PR is to reduce unnecessary Configure tasks on Proxmox triggered by Convoy when the effective VM configuration is already correct. Convoy still sends updates for settings that do not actually need to change, such as hostnames, cloud-init network configuration, hardware values, and parts of the net0 configuration. This PR avoids those no-op updates by comparing the desired state with the current Proxmox state before sending changes. The goal is to reduce task spam and avoid unnecessary reconfiguration noise. I also added a retry backoff and increased the retry budget for password update jobs. In my case, this helped with failed VM creation flows where UpdatePasswordJob could fail while Proxmox was still busy after slow disk resize operations.