Skip to content

fix(editor): refresh framework state after onboarding changes#130

Merged
DavidBabinec merged 1 commit into
mainfrom
fix/onboarding-framework-refresh
Jun 30, 2026
Merged

fix(editor): refresh framework state after onboarding changes#130
DavidBabinec merged 1 commit into
mainfrom
fix/onboarding-framework-refresh

Conversation

@DavidBabinec

Copy link
Copy Markdown
Contributor

Summary

  • Retain CMS site reload requests until the Site editor actually hydrates the fresh site document.
  • Route framework/settings saves through the retained reload helper so dashboard and settings changes share the same behavior.
  • Add regression coverage for a cancelled Site editor mount preserving the pending reload.

Root Cause

The pending CMS site reload flag was consumed before the async Site load resolved. If the persistence hook unmounted before hydration, the next mount treated the stale editor store as authoritative and skipped the refetch, so onboarding framework changes only appeared after a hard refresh.

Verification

  • bun run build
  • bun test (5863 pass, 0 fail)
  • bun run lint
  • Browser smoke: with a local SQLite dev server, Dashboard Core Framework remove/import reflected in the Site editor without a hard refresh.

@DavidBabinec DavidBabinec marked this pull request as ready for review June 30, 2026 23:47
@DavidBabinec DavidBabinec merged commit 97d7392 into main Jun 30, 2026
6 checks passed
@DavidBabinec DavidBabinec deleted the fix/onboarding-framework-refresh branch June 30, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant