Skip to content

Resetting flags every promo piece type.#113

Closed
activey wants to merge 1 commit into
CorentinGS:mainfrom
activey:patch/sticky-flags-when-promoting
Closed

Resetting flags every promo piece type.#113
activey wants to merge 1 commit into
CorentinGS:mainfrom
activey:patch/sticky-flags-when-promoting

Conversation

@activey
Copy link
Copy Markdown

@activey activey commented May 31, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.19%. Comparing base (abc72cb) to head (2269c01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   70.18%   70.19%           
=======================================
  Files          27       27           
  Lines        4166     4167    +1     
=======================================
+ Hits         2924     2925    +1     
  Misses       1110     1110           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@activey
Copy link
Copy Markdown
Author

activey commented Jun 2, 2026

hi @CorentinGS it seems there is some small issue with CI setup

@CorentinGS
Copy link
Copy Markdown
Owner

Thanks for the PR, but resetting m.tags = 0 in the loop only patches the symptom.

The root issue is that addTags mutates state (m.tags |= tag), leaking stale tags whenever a move is reused. PR #116 fixes the underlying design by converting this to a pure function: m.tags = moveTags(m, pos).

Closing this in favor of the structural fix over there.

@CorentinGS CorentinGS closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants