IBC implementation review#234
Draft
DariuszDepta wants to merge 39 commits into
Draft
Conversation
chipshort
reviewed
Apr 9, 2025
Contributor
chipshort
left a comment
chipshort
left a comment
There was a problem hiding this comment.
Some comments about two of the issues. Have to look deeper into the other one.
| self.process_ibc_response(api, contract_addr, storage, router, block, res) | ||
| } | ||
|
|
||
| fn ibc_packet_receive( |
Contributor
There was a problem hiding this comment.
In order to handle #197, you need to make sure that if contract.ibc_packet_receive returns an Err variant, this should not result in an error of this whole ibc_packet_receive function. It should instead return a json-encoded StdAck::Error(err_msg) where err_msg is the stringified error from the contract.
as documented in the CosmWasm IBC docs and implemented in Wasmd.
Comment on lines
+339
to
+340
| // No acknowledgment needed | ||
| Ok(AppIbcReceiveResponse::default()) |
Contributor
There was a problem hiding this comment.
For #194, this should be the success ack (don't know about events or if we care to emulate the correct values there):
Suggested change
| // No acknowledgment needed | |
| Ok(AppIbcReceiveResponse::default()) | |
| Ok(AppIbcReceiveResponse { | |
| events: vec![], | |
| acknowledgement: Some(StdAck::success(b"\x01").to_binary()), | |
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.