Replace serde/jsonschema derives with cosmwasm_schema::cw_serde#910
Open
Buckram123 wants to merge 1 commit intoCosmWasm:mainfrom
Open
Replace serde/jsonschema derives with cosmwasm_schema::cw_serde#910Buckram123 wants to merge 1 commit intoCosmWasm:mainfrom
cosmwasm_schema::cw_serde#910Buckram123 wants to merge 1 commit intoCosmWasm:mainfrom
Conversation
Buckram123
commented
Aug 31, 2024
Comment on lines
+33
to
+34
| #[cw_serde] | ||
| #[derive(Copy, Eq)] |
Author
There was a problem hiding this comment.
cw_serde have rename_all = "snake_case". It shouldn't have any difference from lowercase for those variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce derive boilerplate with
cw_serdemacro. Originally I was missingDebugderive for cw20 base MigrateMsg and noticed that in this repo sometimescw_serdemacro used, sometimesderive(Serialize, Deserialze...)