Skip to content

Bugfix/metrics config handler training conf namespace#211

Merged
ChaitanyaChawak merged 2 commits into
developfrom
bugfix/metrics_config_handler_training_conf_namespace
Apr 13, 2026
Merged

Bugfix/metrics config handler training conf namespace#211
ChaitanyaChawak merged 2 commits into
developfrom
bugfix/metrics_config_handler_training_conf_namespace

Conversation

@jeipollack

@jeipollack jeipollack commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a small namespace bug in the metrics_config_handler.py identified when running the develop branch on simulated validation data.

2026-04-10 21:44:03,908 - wf_psf.metrics.metrics_config_handler - INFO - Running metrics evaluation on trained PSF model...
2026-04-10 21:44:03,908 - wf_psf.data.data_adapter - INFO - Split data already exists; reusing existing train/test split (idempotent call).
2026-04-10 21:44:07,573 - wavediff - ERROR - Check your config file /sps/euclid/Users/jpollack/Euclid-PSF/validation/vxx/v1xx/v1_1_0/configs.yaml for errors. Error Msg: 'RecursiveNamespace' object has no attribute 'training'.

The training attribute

What’s changed

  • Updated Tensorflow to 2.15.0 and Numpy to >=1.23.5, <2.0.0 in pyproject.toml
  • Fixed namespace error involving passing the training configuration object to evaluate_model in metrics_config_handler.py

How to test / verify

Outline steps for reviewers or maintainers to validate the changes.
Include commands, scripts, or datasets if relevant.
Full validation results should be referenced in the associated issue, not pasted here.

  • Ran WaveDiff training and metrics pipeline tasks sequentially on simulated dataset in short-run mode and observed pipeline executed to completion without error
  • Ran WaveDiff metrics pipeline on previously trained model in long run mode and observed pipeline executed to completion without error and the results are consistent with previous validation runs. Small precision errors observed but I am running at CC-IN2P3, with newer version of TF, Adam optimizer, possibly different random seed.

Scope

Indicate the type of PR:

  • Feature
  • Bug fix
  • Hotfix
  • Documentation / process change
  • Internal / refactor
  • Release

Optionally, note if this PR is part of a larger milestone or set of related PRs.

Changelog

Did this PR introduce user-visible changes?
If yes, a Scriv changelog fragment must be added and committed.

  • Changelog fragment added (if applicable)
    No, I will update the changelog for the release branch.

Reviewer Checklist

Reviewers should confirm the following before approving and merging:

  • The PR targets the correct base branch (develop, or main for release PRs)
  • The PR is assigned to the developer
  • Appropriate labels are applied
  • The PR is included in relevant projects and/or milestones
  • Description clearly explains what has changed
  • Issue references included, if applicable
  • Code and documentation adhere to current standards (ruff)
  • Documentation updates included, if relevant
  • CI tests are passing
  • All reviewer comments have been addressed

Next Steps / Notes (if applicable)

Any follow-up actions, known issues, or reminders for maintainers.

@jeipollack jeipollack self-assigned this Apr 13, 2026
@jeipollack jeipollack added the bug Something isn't working label Apr 13, 2026
@ChaitanyaChawak ChaitanyaChawak merged commit 2c9c3f8 into develop Apr 13, 2026
2 checks passed
@ChaitanyaChawak ChaitanyaChawak deleted the bugfix/metrics_config_handler_training_conf_namespace branch April 13, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

2 participants