Skip to content

220 bug inference arbitrary fov positions#221

Merged
ChaitanyaChawak merged 3 commits into
developfrom
220-bug-inference-arbitrary-fov-positions
Jun 4, 2026
Merged

220 bug inference arbitrary fov positions#221
ChaitanyaChawak merged 3 commits into
developfrom
220-bug-inference-arbitrary-fov-positions

Conversation

@jeipollack

@jeipollack jeipollack commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Inference doesn't work for random positions in FOV limits described in #220.

Closes #220

What’s changed

  • Updates to psf_inference.py and psf_inference_test.py
  • Replace model_data_adapter.complete_data with inference_data_adapter.complete_data in the data arg to load_trained_psf_model function
  • Add helper _convert_inference_data_to_tensorflow
  • Change orchestration of data adaptation by doing the conversion after the trained psf model has been loaded

How to test / verify

Outline steps for reviewers or maintainers to validate the changes.
Include commands, scripts, or datasets if relevant.
Full validation results should be referenced in the associated issue, not pasted here.

Scope

Indicate the type of PR:

  • Feature
  • Bug fix
  • Hotfix
  • Documentation / process change
  • Internal / refactor
  • Release

Optionally, note if this PR is part of a larger milestone or set of related PRs.

Changelog

Did this PR introduce user-visible changes?
If yes, a Scriv changelog fragment must be added and committed.

  • Changelog fragment added (if applicable)

Reviewer Checklist

Reviewers should confirm the following before approving and merging:

  • The PR targets the correct base branch (develop, or main for release PRs)
  • The PR is assigned to the developer
  • Appropriate labels are applied
  • The PR is included in relevant projects and/or milestones
  • Description clearly explains what has changed
  • Issue references included, if applicable
  • Code and documentation adhere to current standards (ruff)
  • Documentation updates included, if relevant
  • CI tests are passing
  • All reviewer comments have been addressed

Next Steps / Notes (if applicable)

Any follow-up actions, known issues, or reminders for maintainers.

@jeipollack jeipollack self-assigned this Jun 3, 2026
@jeipollack jeipollack added the bug Something isn't working label Jun 3, 2026
@jeipollack jeipollack added this to the WaveDiff Real Data Handling milestone Jun 3, 2026
@jeipollack

Copy link
Copy Markdown
Contributor Author

@ChaitanyaChawak can you review this PR after the big one #219 ? I will rebase when it's merged

Jennifer Pollack added 3 commits June 4, 2026 09:13
…adapter

- Add helper method for converting inference data to tensorflow type
- Re-arrange sequence of data adaptation
- Replace model_data_adapter with inference_data_adapter
@jeipollack jeipollack force-pushed the 220-bug-inference-arbitrary-fov-positions branch from 1cc33d0 to 904950c Compare June 4, 2026 07:13
@ChaitanyaChawak ChaitanyaChawak merged commit 387429f into develop Jun 4, 2026
2 checks passed
@ChaitanyaChawak ChaitanyaChawak deleted the 220-bug-inference-arbitrary-fov-positions branch June 4, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

2 participants