220 bug inference arbitrary fov positions#221
Merged
ChaitanyaChawak merged 3 commits intoJun 4, 2026
Conversation
Contributor
Author
|
@ChaitanyaChawak can you review this PR after the big one #219 ? I will rebase when it's merged |
added 3 commits
June 4, 2026 09:13
…adapter - Add helper method for converting inference data to tensorflow type - Re-arrange sequence of data adaptation - Replace model_data_adapter with inference_data_adapter
1cc33d0 to
904950c
Compare
ChaitanyaChawak
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inference doesn't work for random positions in FOV limits described in #220.
Closes #220
What’s changed
psf_inference.pyandpsf_inference_test.pymodel_data_adapter.complete_datawithinference_data_adapter.complete_datain thedataarg toload_trained_psf_modelfunction_convert_inference_data_to_tensorflowHow to test / verify
TFPhysicalPolychromaticFieldfails for arbitrary FOV positions due to exact-match lookup infind_position_indices#220 comment repeatability exercise for EVALUATION data schema passScope
Changelog
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes (if applicable)