Fix query infrastructure regressions breaking observable queries#2085
Merged
Conversation
…b demultiplexer Calling subject.OnCompleted() when a hub subscriber's Rx subscription is disposed permanently terminates the shared BehaviorSubject. Any subsequent subscriber on the same query then receives the completed signal and observes no elements, causing Observable.FirstAsync() to throw 'Sequence contains no elements'. Remove the OnCompleted() call from the dispose action so that the shared subject lives independently of individual client connections — matching the existing pattern in ClientObservable.
The backend serializes ObservableQueryHubMessageType as strings via JsonStringEnumConverter, but the TypeScript HubMessageType enum used integer values (0-7). This caused all inbound type comparisons to fail on the client, so hub subscriptions never delivered results. Update the enum to match the string values emitted by the server.
…ty objects
Non-enumerable no-data fallback was changed from null to {}, and the ??
guards in QueryResultWithState.empty/initial/fromQueryResult were replacing
null/undefined defaultValues with []. Both caused hasData to return true
when there was no data, breaking the null-check contract.
Restore the original behaviour: pass values through without substitution
and let null/undefined propagate so hasData reflects true absence of data.
Update specs to assert the corrected contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Sequence contains no elementsHubMessageTypeTypeScript enum using integer values instead of strings, causing all inbound hub message type comparisons to fail silentlyQueryResultandQueryResultWithStatereplacingnull/undefineddata with empty objects/arrays, causinghasDatato returntruewhen there was no data