Skip to content

Fix multiplexed SSE query argument forwarding#2171

Merged
einari merged 2 commits into
mainfrom
fix/multiplexed-sse-query-arguments
Apr 27, 2026
Merged

Fix multiplexed SSE query argument forwarding#2171
einari merged 2 commits into
mainfrom
fix/multiplexed-sse-query-arguments

Conversation

@einari
Copy link
Copy Markdown
Contributor

@einari einari commented Apr 27, 2026

Fixed

  • Fixed hub-mode observable query subscriptions to forward route arguments when direct mode is disabled, so required query values are available in multiplexed SSE mode.
  • Fixed multiplexed subscription argument serialization to omit null and undefined values instead of sending invalid placeholders.
  • Fixed lint noise in the command scope validation failure spec by removing an unused symbol.

Added

  • Added regression specs that verify hub-mode SSE subscribe requests include route and query arguments.
  • Added regression specs that verify null and undefined arguments are omitted from subscribe payloads.

einari added 2 commits April 27, 2026 16:29
Include route parameters in hub-mode subscribe payloads so required query values are available when direct mode is disabled.

Also skip null and undefined values when serializing subscription arguments, and add regression specs for both route/query argument propagation and null argument omission.
The Arc.React workspace CI failed on an unused variable/import in the validation-failure spec.

Remove the dead symbol so root yarn ci succeeds without lint noise.
@einari einari added the patch label Apr 27, 2026
@einari einari merged commit 5ce17ef into main Apr 27, 2026
6 checks passed
@einari einari deleted the fix/multiplexed-sse-query-arguments branch April 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant