Fix ProxyGenerator missing types when referenced only as dictionary value types#2193
Merged
Merged
Conversation
…peDescriptors generated IsKnownType() returns true for IDictionary<K,V>, which caused CollectTypesInvolved to skip dictionary properties entirely — never collecting the value types (e.g. FromDefinition, JoinDefinition, ProjectionChildrenDefinition) into the global typesInvolved list. These types therefore had no TypeDescriptors generated and appeared as self-referential imports instead of inline class definitions. Mirror the dictionary value type collection already present in ToTypeDescriptor into all three CollectTypesInvolved overloads: for PropertyDescriptor, for RequestParameterDescriptor, and for Type. When a property is a dictionary, recurse into the value type while still skipping the dictionary type itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
IDictionary<EventType, FromDefinition>) were not collected intotypesInvolvedand therefore had no TypeScript generated for them. They instead appeared as self-referential imports in the combined output file.CollectTypesInvolvednow recurses into dictionary value types in all three overloads (forType,PropertyDescriptor, andRequestParameterDescriptor).