[FEAT] Multisig support when using WalletConnect#84
Open
mihaic195 wants to merge 2 commits intoCreit-Tech:mainfrom
Open
[FEAT] Multisig support when using WalletConnect#84mihaic195 wants to merge 2 commits intoCreit-Tech:mainfrom
mihaic195 wants to merge 2 commits intoCreit-Tech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signAndSubmitTransactionmethod to the WalletConnect module, enabling wallets to sign and submit transactions to the network in a single step.stellar_signAndSubmitXDRmethod is requested as an optional WalletConnect capability, so wallets that don't support it won't be affected during session pairing.ModuleInterfaceso non-WalletConnect modules are unaffected.I tested this successfully on Stellar mainnet using Lobstr and Lobstr Vault multisig when connected using WalletConnect. Original flows work the same as before, with no regressions.