feat: migrate ABViewForm to plugin architecture#701
feat: migrate ABViewForm to plugin architecture#701Joshua-ChiangMai wants to merge 1 commit intomasterfrom
Conversation
Joshua-ChiangMai
added
the
patch
Lighthouse Performance ReportMetrics📄Full Report |
johnny-hausman
left a comment
johnny-hausman
left a comment
There was a problem hiding this comment.
OK, good start.
Now we will need to slowly pull these external files into your plugin.
| const ABAbviewformComponent = FNAbviewformComponent({ ABViewComponentPlugin }); | ||
|
|
||
| const ABRecordRule = require("../../../../rules/ABViewRuleListFormRecordRules"); | ||
| const ABSubmitRule = require("../../../../rules/ABViewRuleListFormSubmitRules"); |
There was a problem hiding this comment.
As a plugin, our goal is to make sure the plugin has all the code it needs internally or passed in via the APIObject ( meaning: FNAbviewform( APIObject ) ).
Here we are accessing two files that are still embedded in the main AppBuilder Code base. We are going to need to migrate these files INTO your plugin.
That means you will have to pull in ALOT of additional files here. Organize them into a view_form/rules, view_form/rules/ruleActions. like they are in the main code base.
| import ABViewFormItem from "../../../views/ABViewFormItem.js"; | ||
| import ABViewFormCustom from "../../../views/ABViewFormCustom.js"; | ||
| import ABViewFormTextbox from "../../../views/ABViewFormTextbox.js"; | ||
| import ABViewFormJson from "../../../views/ABViewFormJson.js"; |
There was a problem hiding this comment.
Like my comment above, we will need to figure out how to embed these files into the Form Plugin.
|
Also, have you ran the tests on your local machine to see what the errors are? |
I tested the functionality manually in the web app locally, but I haven’t run the e2e tests yet. I’ll run them today and see what’s causing the failures. Thanks. |
2 participants
migrate ABViewForm to plugin architecture