Simple multisig contracts for Tezos FA1.2 and FA2 tokens#88
Simple multisig contracts for Tezos FA1.2 and FA2 tokens#88hugobucquet wants to merge 40 commits intomasterfrom
Conversation
multisig/tests/FA12tests.py
Outdated
|
|
||
| # multisig_wallet.transfer(sp.record(receiver = alice.address, amount = 10, tokenAddress = c1.address)).run(sender = admin.address) | ||
| # multisig_wallet.signAndExecute(0).run(sender = alice.address) | ||
| # multisig_wallet.recoverToken(sp.record(receiver = alice.address, amount = 10, tokenAddress = c1.address)).run(sender = admin.address) |
There was a problem hiding this comment.
Let's set the threshold to two and then test recovery.
gdsoumya
left a comment
gdsoumya
left a comment
There was a problem hiding this comment.
lgtm, have we deployed the contracts and tested them on testnet?
multisig/multisigFA12.py
Outdated
| make_burn = sp.contract(sp.TRecord(address = sp.TAddress, value= sp.TNat), self.data.transferMap[id].tokenAddress, "burn").open_some() | ||
| sp.transfer(sp.record(address = self.data.transferMap[id].sender, value = self.data.transferMap[id].amount), sp.tez(0), make_burn) |
There was a problem hiding this comment.
burn entry point may or may not be available in the old contracts, burn is supposed to be a normal transfer to the burn address
There was a problem hiding this comment.
so should I remove the burn function on the FA1.2?
There was a problem hiding this comment.
yes you can, but that just an example fa1.2 contract we already have the real token contracts deployed and I am pretty sure those don't have the burn function so change the multisig too.
There was a problem hiding this comment.
Yes ok I meant remove it on the FA1.2 multisig 👍
yes have have depoyed them on testnet, but I haven't tested all functionnalities. But the smartpy tests work |
vishakh
changed the title
3 participants
Uh oh!
There was an error while loading. Please reload this page.