Add cherry_grove to Stronghold biomes exclusion list #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpple
added a commit
to xpple/SeedMapper
that referenced
this pull request
Apr 17, 2025
Author
|
See my message in the linked issue regarding the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137. I also verified no other biomes were forgotten by comparing
MultiNoiseBiomeSourceParameterList.Preset.OVERWORLD.usedBiomes()minus the exclusion list inisStrongholdBiometoBiomeTags.STRONGHOLD_BIASED_TO.While the current implementation works, perhaps it is easier to invert the
isStrongholdBiomefunction in the future. So instead of an exclusion list, make it similar toBiomeTags.STRONGHOLD_BIASED_TOby listing what biomes are preferred.