[lib/entropy_common] remove checking on error. Change '&' to '&&' at the while loop condition.#117
Open
TheVice wants to merge 1 commit intoCyan4973:devfrom
Open
[lib/entropy_common] remove checking on error. Change '&' to '&&' at the while loop condition.#117TheVice wants to merge 1 commit intoCyan4973:devfrom
TheVice wants to merge 1 commit intoCyan4973:devfrom
Conversation
Changed '&' to '&&' at the while loop condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
While reading source code at the repository I detected that, checking at the
FSE_readNCountfunction oflib/entropy_common.cfile on error is not necessary - from the outside of function at least. Because same result will be returned, unless corruption of the data was detected.Probably possibility to set brake point on that line or addition output from the error function will be the reason to left such checking.
Latter in this function at the while loop condition - placed bit operation instead of checking on logical AND.
Proposed to replaced with the last one.
Thank you.