tests: add testbed for dev-dependencies of workspaces#564
Conversation
Up to standards ✅🟢 Issues
|
jkowalleck
left a comment
There was a problem hiding this comment.
Please add a README to the new test bed: tests/_data/testbeds/workspace-peer-dev-dependencies/README.md
it should hold the details of this test bed, and what it is showcasing, along with its specialties.
Also add a link to the respective ticket 563.
This README could basically be a modified version of this PR's description.
Thank you in advance.
| "private": true, | ||
| "name": "demo-workspace-peer-dev-dependencies", | ||
| "version": "0.0.1", | ||
| "description": "demo: regression test transitive dev dependency omission with --prod flag in virtual workspace", |
There was a problem hiding this comment.
add a remark that this is about dev-dependnecies of workspaces.
|
some snapshots seam outdated |
…CycloneDX#256) Signed-off-by: RickTimmer <ricktimmer98@gmail.com>
1f8b702 to
03de305
Compare
|
Hi, thanks for having a look again. I took care of your remarks, have another look. After it's been merged I'll rebase my fix branch. Let me know if you'd prefer to first see the CI fail based on the diff in the snapshots, or whether just the diff in the snapshots is fine. Kind regards |
Description
As requested in #563.
This PR adds some testbeds proving an issue, here we can see that after creating the bill of materials with the --production flag we still see the "is-number" package show up. This is a devDependency of a child workspace, which is caught because of a bug concerning virtualized workspaces. The reason for the virtual workspace being used is the fact that the child workspace uses a peerDependency (Intended by Yarn/Berry design).
(personally I just used grep for a quick confirmation
grep -c is-number tests/_data/snapshots/prod-arg_workspace-peer-dev-dependencies.json.bin)AI Tool Disclosure
Claude (claude.ai)Claude Opus 4.8Diagnosing why --prod includes transitive workspace devDependencies,Generate test-suite for this case, andfill in this PR description formAffirmation