chore: fix internal helper script for tools splitting#94
Merged
jkowalleck merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
chore/fix-helper-tools-split
branch
from
e6ccded to
9f42fab
Compare
jkowalleck
commented
Feb 19, 2026
| from_file = t.get('_fromFile') | ||
| name = t['name'] | ||
| return f'{id_}.json' if id_ \ | ||
| return f'{Path(from_file).name}' if from_file \ |
Member
Author
There was a problem hiding this comment.
Fixed a path‑traversal vulnerability in filename handling by using Path(...).name. Reported by user @sonuoffsec
jkowalleck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: fixed the internal helper script for tools splitting. and already applied it - which lead to some JSON whitespace changes.
SEC: Addressed a path‑traversal vulnerability where filenames were derived from untrusted input. The fix now uses
Path(...).nameto ensure only the basename is used. Reported by user @sonuoffsec