Lam/jlib#226
Open
lamorton wants to merge 8 commits into
Open
Conversation
…ng Fortran subroutines.
…iable types. Also fixing the array size from within Julia so that I can properly preallocate the array.
…mbers whether it has been called already & if so doesn't repeat itself & crash.
… is broken right now (doesn't crash, just produces garbage).
…dardized on c_long/c_double as defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pass at making Python & Julia interfaces to subroutines in
fidasim.f90modulelibfida. I modified themakeinstructions to produce a.soshared object for the Fortran wrappers incx_helper.f90.This file uses C bindings to avoid Fortran name-mangling & standardize the numerickinds. The wrappers also to manage hidden global variables (ex: atomic tables) to allow the subroutines to function autonomously. This approach does not require modifications tofidasim.f90.However, it might be more convenient in the future to bring the C bindings directly intofidasim.f90.Julia uses
ccallto easily call the shared library. I'm using theCFFI(C foreign function interface) library in Python. There's a lot of boilerplate involved.