Conversation
Added icons to each type of order line for colorblind people Added highlighting in the tooltip for what state is actually the current state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes about?
Added a proper button to enter the lagerstatus mode, this is much more visible for new users
Updated the colors to be more pleaseing to the eye and less in your face
Updated the way that colors and the states are handled to use a central color definition instead of using repeated and duplicated hex values as state management
https://github.com/DANOSOFT/saldi/pull/213/changes#diff-bac467ef2105a90f895068c804d8227fc7cf416481b21b62d251e96b5c1164c9R176-R181
Added a highlight in the tooltip that shows what state the current row is in
Swapped the flow within the tooltip so it goes
It is a more natural flow than what was there before
Removed title tag from order numbers when in lager status mode (this was blocking the lager status popup)
Fixed translation key for magenta (had gotten overwritten)
Added a back button to exit the lagerstatus view, before the only way to exit was to go to offers and go back to orders
Have you checked the following?
https://docs.google.com/document/d/1GOmomtvKf21OV2VWNOIPweDi4gJHpMCK5qXzrPrypUc/edit?usp=sharing