Skip to content

Fix dropshipping address lookup: preserve order ID across grid navigation#214

Open
logicguy1 wants to merge 2 commits intomasterfrom
dropshipping-fix
Open

Fix dropshipping address lookup: preserve order ID across grid navigation#214
logicguy1 wants to merge 2 commits intomasterfrom
dropshipping-fix

Conversation

@logicguy1
Copy link
Contributor

What are the changes about?

  • Fixed a fatal error when selecting an address in the dropshipping lookup $id (order ID) was lost when the datagrid form submitted for sorting, searching or pagination, because the GET form discards all URL parameters not included as hidden inputs
  • Added an extraParams option to create_datagrid / render_datagrid in grid.php, allowing callers to inject arbitrary hidden inputs into the grid form. Backwards compatible all existing grids are unaffected
  • Fixed double scrollbar in the dropshipping grid by wrapping it in a 89% height container
  • Made the "Leveringsadresse opslag" button visually clearer that it is clickable (not just a label), and gave it a dedicated translation key (2954) across DA/EN/NO

Have you checked the following?

Added extra custom fields to be saved in the GET params for datagrid
Fixed styled overflow in dropshipping system causing dubble scroll behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant