fix: restore chat autoscroll on send#522
Closed
Yezh1i wants to merge 5 commits into
Closed
Conversation
Author
|
Superseded by #523, which contains the verified final implementation as a clean single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Pending user messages are marked
isPending, but the live-anchor lookup started one item before the first live message. As a result, the newly appended user item was skipped and the message scroller could not find a newscrollAnchorto jump to when the viewport was away from the bottom.Testing
pnpm --filter @deeix/web testpnpm --filter @deeix/web typecheckpnpm --filter @deeix/web lintpnpm --filter @deeix/web build