Non-Custodial Partner Program — partner statistic completion funnels - #4529
Closed
joshuakrueger-dfx wants to merge 1 commit into
Closed
Non-Custodial Partner Program — partner statistic completion funnels#4529joshuakrueger-dfx wants to merge 1 commit into
joshuakrueger-dfx wants to merge 1 commit into
Conversation
Add stage A (payment-info request → payment received) and stage B (settlement received → delivered / rejected / in progress) to the partner summary. Funnel members form additive groups and use the same block suppression as period totals: if any counter is under the threshold the whole direction funnel and its rate are null, so rejected = received − delivered − inProgress cannot be reconstructed from visible fields.
joshuakrueger-dfx
force-pushed
the
feat/partner-statistics
branch
from
July 31, 2026 07:32
06c1896 to
9bf880c
Compare
joshuakrueger-dfx
force-pushed
the
feat/partner-statistics-completion
branch
from
July 31, 2026 07:32
71d1972 to
7b81b9b
Compare
Collaborator
Author
|
Superseded — reopened as a fresh PR on the corrected revision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stacked on #4528 — merge that one first, otherwise this PR's diff pulls the aggregates in with it.
Adds the two completion funnels: how many payment-info requests turn into an actual payment, and how
many received payments are delivered rather than stalling.
Honest scope note
Cake did not ask for this. Their request named volume, user counts and popular coins — all covered
by #4528. These metrics were requested internally, and the only figures I have are global rather
than per partner: in 2026, 222,400 payment-info requests against 17,179 actual payments. Whether
that ratio looks different for any individual partner cannot be answered until this endpoint exists.
Reviewers should weigh the review cost against that.
What
Two funnels, deliberately not multiplied into one number — they have different denominators.
Globally stage A sits near 7% and stage B near 96%; a single combined figure would mean nothing.
Stage A is not a conversion rate and is not labelled as one. A
transaction_requestrow iscreated on every payment-info call, so on every amount change in the frontend — not once per
purchase intent. The field names and
@ApiPropertydescriptions say so explicitly.Both funnels are additive by construction (
requestedis the sum of the three statuses;inProgressis defined asreceived − delivered − rejected), so a per-cell suppression woulddisclose the hidden member by subtraction. They therefore use the block suppression introduced in
#4528: if any member falls below the threshold, the whole funnel object is suppressed.
settlement.receivedcounts all rows whiletotals.transactionsin #4528 counts only AML-passedones. That difference is intentional and documented on the DTO — a dashboard summing them will not
reconcile.
Verification
lintempty,format:checkclean,tsc --noEmitclean.distinct-user threshold removed → red.