Release: develop -> main - #4549
Merged
Merged
Conversation
payment.dfx.swiss has served a 301 redirect to app.dfx.swiss since 2026-07-22, so PAYMENT_URL no longer designates a distinct frontend. Config.frontend.payment had no consumers even before that. Verified on develop (dd59d8a): - references to frontend.payment outside config.ts: 0 - positive controls from the same search: frontend.services 24, isRedirectUrlAllowed/allowedUrls 2 - no dynamic access (no "frontend[") and no spread or serialization of the frontend object, so nothing observes the property at runtime SERVICES_URL stays two-valued on purpose: the second entry feeds allowedUrls for redirect-URL validation. The Bicep template still declares the parameter; that belongs to the App Service deployment path and is left untouched here.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 31, 2026 22:11
* fix(gs): disable the /gs/support endpoint pending key validation
The `key` query parameter of this endpoint reaches the query builders behind `GsService.getSupportData` without being restricted to the columns of the target entity. Disable the route until that validation is in place: the handler now rejects every request with 503 and the service is no longer reached.
Internal support tooling that reads from this endpoint is unavailable until the follow-up change lands.
* refactor(gs): drive the /gs/support kill switch from the config
Follow the master-switch pattern already used for the ledger: the endpoint reads a hard-coded flag in `Config.support` that ships off and states, next to the switch, what has to hold before it goes back on. The handler keeps its DTO, so the switch is the only thing that decides.
Reject with `ForbiddenException('Endpoint disabled')` like the neighbouring `/gs/db` handlers instead of `ServiceUnavailableException`, which CONTRIBUTING.md reserves for external outages.
* fix(gs): tighten the support switch comment and its spec setup
Keep the switch comment to the condition for turning it back on, and name the endpoint by its real path. Install the module-level `Config` in the spec through the ConfigService constructor instead of a discarded provider call, and pin the switch explicitly in the rejection test so flipping the shipped default fails exactly the one test that guards it.
TaprootFreak
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist