b360fbab - Translate the limit-request decision form - #1257
Merged
Conversation
All visible form texts go through translate('screens/compliance', ...)
like the surrounding compliance components; the decision enum labels,
clerk names and file names deliberately stay raw. The form test stubs
the settings context with real placeholder interpolation.
Collaborator
Author
|
Review process: 2 full passes (conformity + logic) plus a final combined confirmation pass to zero findings. Pass 1 surfaced two points — the error-detail parentheses sat outside the translation keys, and the error-detail assertions were substring matches — both fixed (keys carry the full wording, assertions compare byte-exact) and re-verified on the final head. Local gates green: 39/39 tests, eslint --max-warnings 0, prettier on the touched files, tsc against the build config; the render output was reconstructed character-for-character against the previous develop wording. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The remaining delta carried over from #1255 (which #1252 superseded): the limit-request decision form was the only compliance component with fully hardcoded UI texts. All visible texts now go through
translate('screens/compliance', …)like the surrounding components — headings, field labels, button states, the per-decision amount hints, the failed-step/already-applied error details and both local error fallbacks. Deliberately kept raw: the three decision enum labels (API values, like the call-queue outcome options), clerk names, file names and API-provided error messages.No logic changes. The form test gains a settings-context stub with real
{{param}}interpolation so the interpolated assertions stay meaningful.Tests
limit-request-decision.test.tsxruns unchanged apart from the new stub; full local gates (tests, lint, prettier on the touched files,tsc -p tsconfig.build.json --noEmit) before ready.