Skip to content

Last core charging signals #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elffjs merged 5 commits into from
Mar 22, 2025
Merged

Last core charging signals #10

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78df379
Just choose something. End this nightmare
elffjs Mar 19, 2025
faffde8
Use the same ordering
elffjs Mar 19, 2025
7651375
Actual -> UnknownType
elffjs Mar 20, 2025
ec37e25
Clean up doc
elffjs Mar 20, 2025
7916ddb
Tweak docs again
elffjs Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions overlays/DIMO/dimo.vspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,15 @@ Vehicle.IsIgnitionOn:
type: sensor
datatype: boolean
description: Vehicle ignition status. False - off, True - on.

Vehicle.Powertrain.TractionBattery.Charging.ChargeCurrent.AC:
datatype: float
type: sensor
unit: A
description: Current AC charging current (rms) at inlet. Negative if returning energy to grid. Used when per-phase numbers are unavailable.
Copy link
Copy Markdown

@KevinJoiner KevinJoiner Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe spell out what rms means

Copy link
Copy Markdown
Member Author

@elffjs elffjs Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is they use it without comment in the main file.

Copy link
Copy Markdown
Member Author

@elffjs elffjs Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you either think about it (hey the current is variable so what are you saying) or it's just a number to you, to be compared with other numbers.

I've never heard of something doing any other summary statistic, to be honest with you.


Vehicle.Powertrain.TractionBattery.Charging.ChargeVoltage.UnknownType:
Copy link
Copy Markdown
Member Author

@elffjs elffjs Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinJoiner @lernerjn Please help

Copy link
Copy Markdown

@KevinJoiner KevinJoiner Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like unkownType because no one is going to use this without looking at the description.

datatype: float
type: sensor
unit: V
description: Current charging voltage at inlet. Used when the data source does not indicate the current type (AC or DC) in use.
Loading