ECO CorneringCounter and ExtremeBrakeCounter

[zakharenkodmytro]

• added CorneringCounter and ExtremeBrakeCounter

[zakharenkodmytro]

@KevinJoiner for viz

[KevinJoiner]

I don't know if we want both extremeBrake and harshBrake can we double check with @zer0stars

[zer0stars]

I feel like it’s 1 thing, which is harsh braking, with a severity value. Sent from my PhoneOn Jun 24, 2025, at 09:59, Kevin Joiner ***@***.***> wrote: @KevinJoiner commented on this pull request. I don't know if we want both extremeBrake and harshBrake can we double check with @zer0stars —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[zakharenkodmytro]

I feel like it’s 1 thing, which is harsh braking, with a severity value. Sent from my PhoneOn Jun 24, 2025, at 09:59, Kevin Joiner @.> wrote: @KevinJoiner commented on this pull request. I don't know if we want both extremeBrake and harshBrake can we double check with @zer0stars —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

Thought that we agreed on that - https://discord.com/channels/892438668453740634/980261367808421939/1385675578778193920. @zer0stars

[zakharenkodmytro]

I feel like it’s 1 thing, which is harsh braking, with a severity value. Sent from my PhoneOn Jun 24, 2025, at 09:59, Kevin Joiner @.> wrote: @KevinJoiner commented on this pull request. I don't know if we want both extremeBrake and harshBrake can we double check with @zer0stars —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: _@**.**_>

Thought that we agreed on that - https://discord.com/channels/892438668453740634/980261367808421939/1385675578778193920. @zer0stars

@zer0stars, please elaborate more on the above

[zer0stars]

Does VSS allow us to add 2 values? or we'd have to have both:
harsh_braking_counter
harsh_braking_severity

[zakharenkodmytro]

Does VSS allow us to add 2 values? or we'd have to have both:
harsh_braking_counter
harsh_braking_severity

You can define signals with different purposes, such as counters and severity levels, but VSS does not inherently support mathematical operations like adding two values directly within the specification. So If we want both harsh_braking_counter and harsh_braking_severity, we would define them as separate signals.

If we need to calculate a combined value (e.g., adding the two), this would need to be handled in the application logic outside of VSS, as VSS is a data modeling specification and does not perform computations.

Though there is new datatype struct introduced, it is not yet supported by vss tools, imo I would not use it unless we have very good reason to.

[JamesReate]

if the only values coming in are 0 or 1, should these be booleans instead?

[LDMO-Dev]

if the only values coming in are 0 or 1, should these be booleans instead?

There has been one case where the counter showed up as 2 for the acceleration counter, but we have been unable to recreate that. Also, the harsh and extreme brake has 4 values, unless we split? We can ask Domas on Tuesday, once he is back in, to figure out if this signal should be acting as a counter or a Boolean.

[zakharenkodmytro]

closing this, @LDMO-Dev feel free to reopen if needed