Merged
Conversation
zer0stars
reviewed
Jan 12, 2026
zer0stars
approved these changes
Jan 12, 2026
Member
|
all good
…On Tue, Jan 13, 2026 at 9:21 AM LDMODEV ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/Cabin/Cabin.vspec
<#20 (comment)>:
> @@ -145,7 +145,7 @@ IsWindowChildLockEngaged:
Seat:
type: branch
instances:
- - Row[1,2]
+ - Row[1,3]
I had to increase the number of cabin rows to support; CAN Seat belts.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARWSCBPOWWMPTHEUOUSQLHD4GT5NBAVCNFSM6AAAAACROIRO5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJWGA3DKOJQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Yevgeny Khessin*
Co-founder | *DIMO*
Download the App <https://onelink.to/dimo> | Book a time
<https://calendly.com/yev-dimo/30min>
|
Author
|
@zer0stars Can you take a look at the latest commit in this PR and merge PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/dimo/issue/INTG-1917/signal-mapping-r1-can-signals
Had to increase the Row instance's to help with signals;
IsBelted supports 3 rows.
Axle weight CAN signals supports 5 rows.
@zer0stars