Skip to content

R1 device signals#7

Merged
zakharenkodmytro merged 8 commits intomainfrom
R1-Device-Signals
Feb 21, 2025
Merged

R1 device signals#7
zakharenkodmytro merged 8 commits intomainfrom
R1-Device-Signals

Conversation

@Islandboy784
Copy link
Copy Markdown

Ruptela device signals added

datatype: float
description: Length of time vehicle engine was idling since last start up

ECO.IdlingEvent:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also a counter? Why isn't it named like the others?

datatype: float
description: Vehicle idling

MovementSensor:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there units? What does the magnitude of this represent?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to answer what I understand, but I assume that Daniel knew what he was doing

Comment on lines +73 to +96
ECO.BrakingValue:
type: sensor
datatype: float
description: Braking value

ECO.AccelerationValue:
type: sensor
datatype: float
description: Acceleration value

ECO.CorneringValue:
type: sensor
datatype: float
description: Cornering value

UnplugDetection:
type: sensor
datatype: float
description: device unplug detection

CurrentLTEBand:
type: sensor
datatype: float
description: Current LTE band
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear on the interpretation of any of these.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to merge the ignition status for Astreon asap; we can leave the above out of the scope of the current pr. Thoughs?

Copy link
Copy Markdown

@zakharenkodmytro zakharenkodmytro Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually some of vss changes was already in model-garage

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still in the PR. Am I supposed to ignore it? I don't understand.

zakharenkodmytro and others added 2 commits February 21, 2025 15:24
Co-authored-by: Dylan Moreland <79415431+elffjs@users.noreply.github.com>
@zakharenkodmytro zakharenkodmytro merged commit 12202b5 into main Feb 21, 2025
1 of 4 checks passed
@elffjs elffjs deleted the R1-Device-Signals branch February 21, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants