Skip to content

Conversation

@dromer
Copy link
Collaborator

@dromer dromer commented Dec 12, 2025

Solves #883

We basically replace the module major version with APP_VERSION_MAJOR.

This then is only a bit confusing for 1.x modules, but at least we have a usable version number again.

@falkTX
Copy link
Contributor

falkTX commented Dec 12, 2025

If we want to show the real version this is the wrong way to do it.
Fetch the version first, take the major digit from that version and if < 2 (app-major) force the version. Otherwise leave as-is.

@dromer
Copy link
Collaborator Author

dromer commented Dec 12, 2025

Yeah I wanted to do something like that first, but pulling the major version out was a bit of a pain. I figured that just replacing whatever the first character with our major version would be easier and faster.

We can add an int comparison to it if you think that's better, but it feels more wasteful than just forcing the major version.

@dromer dromer force-pushed the feature/module_versions branch from 53affe8 to 4649d3b Compare December 12, 2025 09:33
dromer and others added 3 commits December 12, 2025 13:55
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@falkTX falkTX changed the title force APP_VERSION_MAJOR to module version only force APP_VERSION_MAJOR in modules as necessary Dec 12, 2025
@falkTX falkTX merged commit de38578 into main Dec 12, 2025
42 checks passed
@falkTX falkTX deleted the feature/module_versions branch December 12, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants