Conversation
| t8_forest_write_vtk_ext(forest, file, write_treeid, write_mpirank, | ||
| write_level, write_element_id, write_ghosts, | ||
| 0, 0, num_data, Ref(vtk_data)) | ||
| # TODO: Add MPI barrier |
There was a problem hiding this comment.
Tests fail on one rank because writing the file is not yet finished on the other.
| # TODO: Add MPI barrier | ||
| @test isfile(file * ".pvtu") | ||
| @test isfile(file * "_0000.vtu") | ||
| # TODO: Check file * "0001.vtu" for MPI parallel run |
There was a problem hiding this comment.
If wanted, we could also test the file * "_0001.vtu" for the MPI run
|
@bennibolm With #103 we now have the t8code tutorial examples (except 5 and 6) running in CI with and without MPI. This includes some vtk writing as well. Do you think we need further testing? |
Oh wow. I completely forgot about this PR. Unfortunately, I don't really remember the issues I had. Since nobody got had problems, I guess we don't need further testing. |
|
Tests are still failing, but I believe this is because of your first comment, @bennibolm. If you agree, we can close this PR. |
|
Yes, I'm fine with closing it. |
3 participants
No description provided.