Skip to content

Updated to a working server#2550

Merged
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-nonblock
Jul 10, 2026
Merged

Updated to a working server#2550
jwillemsen merged 1 commit into
DOCGroup:masterfrom
jwillemsen:jwi-nonblock

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Jul 10, 2026

Copy link
Copy Markdown
Member
* ACE/tests/NonBlocking_Conn_Test.cpp:

Summary by CodeRabbit

  • Tests
    • Updated the non-blocking connection test endpoint to use tweakers.net instead of the previous site.

    * ACE/tests/NonBlocking_Conn_Test.cpp:
@mergify

mergify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c3f1d88a-049c-405b-a0f5-518249679e71

📥 Commits

Reviewing files that changed from the base of the PR and between 07c010d and 4fccb0a.

📒 Files selected for processing (1)
  • ACE/tests/NonBlocking_Conn_Test.cpp

Walkthrough

The non-blocking connection test replaces one host target, changing the endpoint from www.russiantvguide.com:80 to tweakers.net:80.

Changes

Connection Test Update

Layer / File(s) Summary
Replace connection test endpoint
ACE/tests/NonBlocking_Conn_Test.cpp
The test host list now includes tweakers.net:80 instead of the previous endpoint.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny hops through hosts tonight,
One endpoint changed to make things right.
Tweakers greets the test with cheer,
While carrots crunch beside the peer.
Connection hops, then disappears!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the change, but it is too vague to clearly describe the updated test endpoint. Use a specific title such as "Replace non-blocking connection test host with a working server".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jwillemsen jwillemsen merged commit eda9d94 into DOCGroup:master Jul 10, 2026
38 checks passed
@jwillemsen jwillemsen deleted the jwi-nonblock branch July 10, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant