Feature/implement oracle bulk insert provider bulk insert return entities#3
Open
alexanderklassen wants to merge 19 commits into
Open
Conversation
- Fix double-schema qualification when EF Core default schema is configured - Clarify table name handling comment
…#2) * Remove trailing semicolon from SQL statements in OracleDialectBuilder and add unit tests to prevent regressions --------- Co-authored-by: Alexander Klassen <alexander.klassen@dedalus.com>
…chema' into all-fixes
…in from a temporary table
…te returning logic
…elease of server-side locks
… column identifiers
| null => "NULL", | ||
| RawSqlValue rawSqlValue => rawSqlValue.Sql, | ||
| Guid guid => FormatGuid(guid), | ||
| string s => $"'{s}'", |
| // Numeric and other formattable values must use the invariant culture so that, for example, | ||
| // a decimal is rendered as "42.5" and not the culture-specific "42,5" which is invalid SQL. | ||
| IFormattable formattable => formattable.ToString(null, CultureInfo.InvariantCulture), | ||
| _ => value.ToString() ?? "NULL", |
Owner
There was a problem hiding this comment.
Kann zu Fehlern führen
throw?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and clarifications to the Oracle provider and documentation for the bulk insert library. The main changes include enhanced documentation of upsert behavior, a new limitation note regarding Oracle transaction rollback, and significant improvements to the Oracle upsert implementation to ensure primary key and match columns are never overwritten. Additionally, it adds a project-specific
NuGet.configfor more reliable package restores and minor code quality improvements.Documentation updates and limitations:
Matchcolumns are never overwritten during upsert operations, even if specified in theUpdateexpression, in bothREADME.mdanddocs/documentation.md. Also explained how constant expressions are handled in upsert expressions. [1] [2]docs/limitations.md: upsert operations usingExecuteBulkInsertReturnEntitiescannot be rolled back in a transaction due to Oracle's implicit commit on DDL statements.Oracle provider upsert and insert improvements:
MERGEstatement. [1] [2]ROWIDs, ensuring the correct entities are returned.Build and configuration:
NuGet.configto ensure package restores use only nuget.org, avoiding unreliable internal mirrors during local development.Miscellaneous:
usingdirective for extensions in the Oracle provider for consistency and clarity..DotSettings.userfile, likely for IDE/test session state (not affecting library behavior).