Fix error message from controlled vocabulary fields remaining hidden after user interaction#4502
Open
alexandrevryghem wants to merge 2 commits intoDSpace:mainfrom
Conversation
… user interaction with the field This was because the blur event was never triggered, so the field still thinks that the field is being focused
…age-after-interaction_contribute-7.6'
alexandrevryghem
added
component: submission
component: controlled vocabulary
|
Hi @alexandrevryghem, |
pzlakowski
reviewed
Mar 2, 2026
pzlakowski
left a comment
pzlakowski
left a comment
There was a problem hiding this comment.
Checklist:
- Merge with the newest main
- Lint test
- Test behavior
- Review code
Subjects to do:
- Merge to current main and resolve merge conflicts
- Check my comments regarding code changes and find whenever you agree with them
I have checked the PR and it work as intended. I have resoled conflicts myself and tested with current main.
Old behaviour:
New behaviour:
| } | ||
| this.inputValue = null; | ||
| onBlur(event: Event, hierarchical: boolean = false): void { | ||
| if (hierarchical) { |
There was a problem hiding this comment.
In my opinion it would be better to rewrite conditional in this style. We remove one level of nested conditionals and we separate precondition which does different responsibility with early return.
if (hierarchical) {
if (!this.vocabularyTreeOpen) {
super.onBlur(event);
}
return;
}
tdonohue
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace 10.0 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixed an issue where
oneboxfields that use vocabularies don't trigger theonBlurevent. This is problematic because error messages are not shown when the field is focused. Because theonBlurevent is responsible for setting thehasFocusboolean tofalseand thatonBlurwas never triggered, the form control remained in thehasFocusstate once you interacted with it until you refreshed the whole page. This caused the error message to always be hidden once you interacted with the field.Instructions for Reviewers
List of changes in this PR:
onBlurevent is now triggered which causes the error message to be displayedonBlurevent will not be triggered, otherwise the value won't be properly setGuidance for how to test this PR: see #4501
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.