Open
Conversation
alanorth
added
code task
1 APPROVAL
alanorth
force-pushed
the
node-prefix-imports
branch
2 times, most recently
from
d76f3da to
0f1295b
Compare
These were missed when we started enforcing the node prefix several months ago.
We need to lint the scripts and webpack helpers as well.
Automatically fix most lint errors.
Now that we are properly linting the scripts directory there are a few new errors we need to fix.
Now that we are properly linting the scripts directory there are a few issues we missed before. This imports the specific modules we need from lodash instead of the entire package.
alanorth
force-pushed
the
node-prefix-imports
branch
from
0f1295b to
254ea5b
Compare
|
Hi @alanorth, |
Contributor
|
@alanorth I'm sorry I didn't look at this sooner. It's mainly formatting and prefixes. Can you fix the conflicts and I'll review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Description
These were missed when we started enforcing the node prefix several months ago because our lint configuration in
angular.jsonwas not considering them.Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
node:prefix to several imports of internal Node.js APIs: fs and pathangular.jsonto considerscriptsandwebpackdirectoriesnpm run lint-fixto automatically fix as many as possiblelodashimport inscripts/merge-i18n-files.tsscripts/sync-i18n-files.tsInclude guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Make sure the dev and prod builds are successful.
Make sure i18n scripts work:
Make sure all tests in CI pass.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.