Skip to content

Made item page fields themeble#5260

Open
alexandrevryghem wants to merge 2 commits intoDSpace:mainfrom
alexandrevryghem:theme-generic-item-page-field_contribute-main
Open

Made item page fields themeble#5260
alexandrevryghem wants to merge 2 commits intoDSpace:mainfrom
alexandrevryghem:theme-generic-item-page-field_contribute-main

Conversation

@alexandrevryghem
Copy link
Member

@alexandrevryghem alexandrevryghem commented Mar 6, 2026

Description

Made the item page fields themable & fixed issue with our custom linting rules that prevented templateUrls to start with ../

Instructions for Reviewers

List of changes in this PR:

  • Created the following themed components
    • ItemPageAbstractFieldComponent
    • ItemPageAuthorFieldComponent
    • ItemPageCcLicenseFieldComponent
    • ItemPageDateFieldComponent
    • GenericItemPageFieldComponent
    • GeospatialItemPageFieldComponent
    • ItemPageUriFieldComponent

Guidance for how to test/review this PR:

  • To test the geospatial field you need to update your configuration to render the map on item page fields by setting geospatialMapViewer.enableItemPageFields to true. You also need to create a new dcterms.spatial metadata field on the item with a WKT value for example Point ( +008.660000 +047.336111 )
  • Set the theme to custom theme in config.yml
    • Verify if the new themable components in the custom theme folder are used instead of the ones from src/app
  • Set the theme to dspace theme in config.yml
    • Verify if the components from src/app are used

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added this to the 10.0 milestone Mar 6, 2026
@alexandrevryghem alexandrevryghem self-assigned this Mar 6, 2026
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Mar 6, 2026
@lgeggleston lgeggleston added new feature component: Item (Archived) Item display or editing improvement and removed new feature labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Item (Archived) Item display or editing improvement themes

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants