Skip to content

Commit 99fa09d

Browse files
committed
Don't set global uniforms in UpdateSurfaceData*
1 parent 7406196 commit 99fa09d

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/engine/renderer/Material.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,6 @@ void UpdateSurfaceDataGeneric3D( uint32_t* materials, Material& material, drawSu
215215

216216
gl_genericShaderMaterial->BindProgram( material.deformIndex );
217217

218-
gl_genericShaderMaterial->SetUniform_ModelMatrix( backEnd.orientation.transformMatrix );
219-
gl_genericShaderMaterial->SetUniform_ModelViewProjectionMatrix( glState.modelViewProjectionMatrix[glState.stackIndex] );
220-
221218
// u_AlphaThreshold
222219
gl_genericShaderMaterial->SetUniform_AlphaTest( pStage->stateBits );
223220

@@ -548,10 +545,6 @@ void UpdateSurfaceDataLiquid( uint32_t* materials, Material& material, drawSurf_
548545
gl_liquidShaderMaterial->SetUniform_FogDensity( fogDensity );
549546
gl_liquidShaderMaterial->SetUniform_FogColor( fogColor );
550547

551-
gl_liquidShaderMaterial->SetUniform_UnprojectMatrix( backEnd.viewParms.unprojectionMatrix );
552-
gl_liquidShaderMaterial->SetUniform_ModelMatrix( backEnd.orientation.transformMatrix );
553-
gl_liquidShaderMaterial->SetUniform_ModelViewProjectionMatrix( glState.modelViewProjectionMatrix[glState.stackIndex] );
554-
555548
// NOTE: specular component is computed by shader.
556549
// FIXME: physical mapping is not implemented.
557550
if ( pStage->enableSpecularMapping ) {
@@ -1183,6 +1176,7 @@ void BindShaderLiquid( Material* material ) {
11831176

11841177
// Set shader uniforms.
11851178
gl_liquidShaderMaterial->SetUniform_ViewOrigin( backEnd.viewParms.orientation.origin );
1179+
gl_liquidShaderMaterial->SetUniform_UnprojectMatrix( backEnd.viewParms.unprojectionMatrix );
11861180
gl_liquidShaderMaterial->SetUniform_ModelMatrix( backEnd.orientation.transformMatrix );
11871181
gl_liquidShaderMaterial->SetUniform_ModelViewProjectionMatrix( glState.modelViewProjectionMatrix[glState.stackIndex] );
11881182

src/engine/renderer/gl_shader.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3458,7 +3458,7 @@ class u_UnprojectMatrix :
34583458
{
34593459
public:
34603460
u_UnprojectMatrix( GLShader *shader ) :
3461-
GLUniformMatrix4f( shader, "u_UnprojectMatrix" )
3461+
GLUniformMatrix4f( shader, "u_UnprojectMatrix", true )
34623462
{
34633463
}
34643464

0 commit comments

Comments
 (0)