Update Compose and compileSdk version, migrate deprecated APIs #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Compose and Android SDK versions while refactoring deprecated APIs and styling components.
- Replace deprecated
rememberRipplewith the newrippleAPI across multiple views. - Refactor
Chipborder handling and remove custom ripple theming inNoRippleIconButton. - Bump
compileSdk/targetSdkto 35 and update the Compose BOM and related dependencies.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| presentation/src/main/java/daily/dayo/presentation/view/*.kt | Replaced rememberRipple imports/usages with ripple |
| presentation/src/main/java/daily/dayo/presentation/view/Chip.kt | Swapped AssistChipDefaults.assistChipBorder for BorderStroke |
| presentation/src/main/java/daily/dayo/presentation/view/Button.kt | Removed custom RippleTheme, updated indication(null) |
| presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt | Added null fallback for versionName |
| presentation/build.gradle | Bumped compileSdk to 35 and restructured Compose BOM setup |
| data/build.gradle | Bumped compileSdk to 35 |
| app/build.gradle | Bumped compileSdk & targetSdk to 35 |
| README.md | Updated documented targetSdkVersion |
Comments suppressed due to low confidence (1)
presentation/build.gradle:89
- This Gradle declaration uses an explicit type (
Dependency) in a Groovy DSL script, which will cause a syntax error. Usedef composeBom = platform('...')or apply the BOM directly in theimplementationcall.
Dependency composeBom = platform('androidx.compose:compose-bom:2025.05.00')
app/build.gradle
Outdated
Comment on lines
29
to
31
| defaultConfig { | ||
| applicationId "com.daily.dayo" | ||
| compileSdk 34 | ||
| compileSdk 35 |
There was a problem hiding this comment.
The compileSdk property appears inside the defaultConfig block; it should be declared directly under the android block (above defaultConfig) to be recognized by the Android plugin.
presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
Member
|
compildSdk나 targetSdkVersion을 바꿀 때마다 모듈 별로 바꿔주고 있는데, 
이런식으로 쓰면 될 것 같습니다 |
…ings/SettingsScreen.kt The getPackageInfo(String, int) call is deprecated on API 33+. switching to getPackageInfo(packageName, PackageManager.PackageInfoFlags.of(0)) to avoid deprecation warnings and ensure forward compatibility. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ndroid block in app module build.gradle
Member
Author
반영하였습니다 |
yuni-ju
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
참고