Migrate Application Notice View from XML to Compose #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt # presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt
… and detail screen.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the application’s Notice view from XML layouts to Jetpack Compose while integrating shared element transitions for smooth navigation. Key changes include the complete removal of XML layouts, updates to the NoticeViewModel to use Kotlin Flows and Resource wrappers instead of LiveData, and new Composable screens with updated navigation for notices.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fragment_notice_list.xml & fragment_notice_detail.xml | Removed legacy XML layouts as part of the migration to Compose. |
| NoticeViewModel.kt | Updated to use StateFlow for detail notices; changed noticeId type from Int to Long and updated API response handling. |
| SettingsScreen.kt & SettingsNavigation.kt | Added parameter for notices navigation and updated corresponding navigation calls. |
| NoticesScreen.kt, NoticeNavigation.kt, NoticeDetailScreen.kt | Introduced new Compose-based screens for displaying the notice list and notice details with shared element transitions. |
| MainScreen.kt, MainNavigator.kt | Integrated the new notice navigation into the main app navigation and incorporated SharedTransitionLayout. |
| Remaining legacy fragments and adapter files | Removed XML-based fragments and adapters in favor of Compose implementations. |
| Domain & Data layers (RequestDetailNoticeUseCase, NoticeRepository, Notice.kt, NoticeRepositoryImpl, NoticeResponse.kt, NoticeApiService.kt) | Updated all noticeId types from Int to Long to maintain consistency. |
Comments suppressed due to low confidence (1)
presentation/src/main/java/daily/dayo/presentation/viewmodel/NoticeViewModel.kt:45
- [nitpick] Consider renaming the lambda parameter 'ApiResponse' to 'response' for clarity and consistency with typical naming conventions.
requestDetailNoticeUseCase(noticeId).let { ApiResponse ->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
참고