Skip to content

Conversation

@DongJun-H
Copy link
Member

작업사항

  • 알림 리스트에서 알림을 보낸 유저 프로필 노출에 대한 반영
    • Notification data model에 대한 필드값 추가

참고

@DongJun-H DongJun-H requested review from Copilot and yuni-ju May 25, 2025 07:08
@DongJun-H DongJun-H self-assigned this May 25, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR surfaces the sender’s profile image in notification list items by propagating a new profileImage field through the network, mapping, domain, and UI layers.

  • Extended the remote AlarmResponse and Notification domain model with profileImage
  • Updated AlarmMapper to include profileImage
  • Modified the Compose UI (NotificationScreen.kt) to load and display the profile image

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
presentation/src/main/java/daily/dayo/presentation/screen/notification/NotificationScreen.kt Added profileImage to defaults and updated RoundImageView URL
domain/src/main/java/daily/dayo/domain/model/Notification.kt Added val profileImage: String? to Notification
data/src/main/java/daily/dayo/data/mapper/AlarmMapper.kt Mapped profileImage from DTO to domain model
data/src/main/java/daily/dayo/data/datasource/remote/alarm/AlarmResponse.kt Added @SerializedName("profileImage") val profileImage: String?
Comments suppressed due to low confidence (2)

domain/src/main/java/daily/dayo/domain/model/Notification.kt:13

  • [nitpick] The Notification data class already has an image property. Introducing profileImage may cause confusion—consider renaming image to something like contentImage or attachmentImage to clarify each field’s purpose.
val profileImage: String?,

data/src/main/java/daily/dayo/data/mapper/AlarmMapper.kt:17

  • You’ve added mapping for profileImage; consider adding a unit test in AlarmMapperTest (or similar) to verify that the DTO’s profileImage correctly maps into the domain model.
profileImage = profileImage,

@github-project-automation github-project-automation bot moved this from Todo to In Progress in DAYO 2.0 May 28, 2025
@DongJun-H DongJun-H merged commit dd70009 into develop Jun 2, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in DAYO 2.0 Jun 2, 2025
@DongJun-H DongJun-H deleted the layout/issue-654 branch June 2, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants