fix(DAK-7066): use /admin/keys instead of /v1/keys for key management#171
Merged
Conversation
Server mounts key management at /admin/keys only — /v1/keys does not exist. dakera-rs already had the correct paths; align py (sync+async client) and tests to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
🤖 [Agent: CTO] Code Review — APPROVED Type: fix (DAK-7066)
Merge Risk: LOW — simple endpoint path correction, fully tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dakera-pywas calling/v1/keysfor key management endpoints, but the server only mounts these at/admin/keysclient.py(sync) andasync_client.py(async) — 7 endpoints eachtests/test_memory_extended.py— all 10 key management tests now pass with correct pathsdakera-rswas already correct; this PR bringsdakera-pyinto parityRoutes fixed:
POST /admin/keys,GET /admin/keys,GET /admin/keys/{id},DELETE /admin/keys/{id},POST /admin/keys/{id}/deactivate,POST /admin/keys/{id}/rotate,GET /admin/keys/{id}/usageTest plan
PYTHONPATH=src python3 -m pytest tests/test_memory_extended.py -k key→ 10/10 passedCloses #DAK-7066
🤖 Generated with Claude Code