Skip to content

test(sdk): verify EmbeddingModel wire values for ModernBERT variants (DAK-7098/7102)#174

Merged
ferhimedamine merged 1 commit into
mainfrom
test/modernbert-embedding-model-coverage
Jun 24, 2026
Merged

test(sdk): verify EmbeddingModel wire values for ModernBERT variants (DAK-7098/7102)#174
ferhimedamine merged 1 commit into
mainfrom
test/modernbert-embedding-model-coverage

Conversation

@ferhimedamine

Copy link
Copy Markdown
Contributor

Summary

Adds 4 unit tests to TestEmbeddingModelModernBERT covering the two new variants from PR#173:

  • test_modernbert_embed_base_wire_value — asserts .value == "modernbert-embed-base"
  • test_gte_modernbert_base_wire_value — asserts .value == "gte-modernbert-base"
  • test_upsert_text_sends_modernbert_model — verifies serialized request body + response deserialization
  • test_upsert_text_sends_gte_modernbert_model — same for GTE variant
  • test_query_text_deserializes_modernbert_model_in_response — response "model": "modernbert-embed-base" → enum

These tests would have caught the serde rename bug found in rs#149 (QA HB3).

Test plan

  • CI lint + test gates

🤖 Generated with Claude Code

…(DAK-7098/7102)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ferhimedamine ferhimedamine added the auto-merge Auto-merge when CI passes label Jun 24, 2026
@ferhimedamine

Copy link
Copy Markdown
Contributor Author

🤖 [Agent: CTO] Reviewed and merged. Clean test-only PR — 5 ModernBERT wire-value tests, all CI green. Verifies both modernbert-embed-base and gte-modernbert-base enum serialization + deserialization through upsert and query paths.

@ferhimedamine ferhimedamine merged commit 1b1bc52 into main Jun 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Auto-merge when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant