refactor: [TA-194] 인라인 함수 props 제거로 불필요한 리렌더링 방지 (useCallback/useMemo)#90
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterBar:handleFilterChange,getDefaultFilters,handleSetFree,handleSetDiscount,handleClearType,handleResetFilter,handleFilter를useCallback으로 메모이제이션,BtnOnOff인라인 함수 props 제거PromotionBox:savePromotionFunc,onClickSave,openDetailPage를useCallback으로,getDDayText(data.endedAt)결과를useMemo로 메모이제이션PhotographerBox:savePhotographerFunc,onClickSave,onClickPhotographer를useCallback으로, 닉네임 truncate 결과를useMemo로 메모이제이션onClick={() => fn()}패턴을onClick={fn}직접 참조로 정리Test plan
Closes #17