feat(T24): remove node-cron daemon and local crontab automation - #10
Merged
Conversation
GitHub Actions is the only automation path actually running in production (every workflow calls a single job via --job=<name>, never `pnpm dev` with no args). The in-process node-cron daemon duplicated schedule definitions already living in the workflow YAML and required a persistently-running process with no supervisor — strictly weaker than both GitHub Actions and the macOS crontab docs it sat alongside. - Remove src/jobs/scheduler.ts and the node-cron/@types/node-cron deps - No-args CLI invocation now prints usage + job list instead of starting a daemon - Keep Job.schedule/timezone on the registry — still used by `pnpm jobs` for informational display - Update README (Commands, Project structure) and stale comments referencing the deleted scheduler Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CtRxtJgwNeyMyTnYxuxoH6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-crondaemon (src/jobs/scheduler.ts,node-cron/@types/node-crondeps) and the "Automate locally (macOS crontab)" README section--job=<name>), never the no-args daemon mode — so this removes dead/redundant machinery, not a used feature.github/workflows/*.yml, a real drift riskJob.schedule/Job.timezonefields stay on the registry — still used bypnpm jobsfor informational displayTest plan
pnpm tsc— no errorspnpm test— all 3 unit tests passpnpm format:check— cleanpnpm jobs— still lists all jobs with schedule info correctlypnpm newsrun post-removal — scrape → curate → Telegram digest sent → saved to DB, confirming the removal didn't affect the actual job execution path🤖 Generated with Claude Code
https://claude.ai/code/session_01CtRxtJgwNeyMyTnYxuxoH6