Hold jsdom at ^29 — v30 raises the Node floor (closes #28) - #30
Merged
Conversation
DanMat
force-pushed
the
chore/bump-jsdom
branch
from
August 1, 2026 16:07
5fe3f57 to
0d8b02a
Compare
The freshness workflow flagged jsdom a major behind, but v30 can't be adopted: it requires Node ^22.22.2 || ^24.15.0 || >=26, above Packkit's engines floors (Node 22 line, and 24.0.0 on the 24 line). Bumping it makes generated projects fail `npm install` with EBADENGINE on the floor — the integration matrix caught exactly that on react/vue/svelte/fullstack. Same class as lint-staged v17: a major that outruns our Node floor. So jsdom joins the HELD map with the reason, and the weekly freshness check now reports it as an intentional hold instead of stale — no more noise. jsdom stays ^29.0.0. Closes #28 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
DanMat
force-pushed
the
chore/bump-jsdom
branch
from
August 1, 2026 16:08
0d8b02a to
c5d3ec6
Compare
DanMat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28 flagged jsdom a major behind. But v30 can't be adopted — it requires Node
^22.22.2 || ^24.15.0 || >=26.0.0, above Packkit's own engines floors (the Node 22 line, and24.0.0on the 24 line).Bumping it makes generated projects fail
npm installwithEBADENGINEat the floor — the integration matrix caught exactly that: react-app, react-lib, vue-app, vue-lib, svelte-app, svelte-lib, and fullstack all failed on Node 24.0.0.This is the same class as
lint-stagedv17: a major that outruns our Node floor. So jsdom joins theHELDmap with the reason, and the weekly freshness check now reports it as an intentional hold instead of stale — no more noise. jsdom stays^29.0.0.Freshness check exits clean. 99 tests pass.
Closes #28
🤖 Generated with Claude Code