fullstack honors --server (Hono | Fastify | Express) — closes #29 - #31
Merged
Conversation
The fullstack preset always scaffolded Hono, ignoring --server / serviceFramework — so a documented override looked broken from the CLI, MCP, and web configurator. Now apps/server is generated per framework, with each serving /api/health (the shared Health shape) and, in production, the built web app from apps/web/dist: - Hono: @hono/node-server serveStatic (default; byte-identical to before) - Express: express.static + supertest tests; app typed as Express to satisfy the workspace's declaration emit (TS2742) - Fastify: @fastify/static (added to the version catalog) + inject tests Exposed across every surface, which was the other half of the bug: - serviceFramework's `when` and the CLI wizard now trigger for the fullstack layout, not only a `service` target, so the picker appears - the web command builder emits `--server` for fullstack, and also `--monorepo-layout` (a pre-existing gap — the fullstack command was unreproducible since 2.9) - preset/option help + the README reference say Hono/Fastify/Express Verified: Hono default byte-identical across all 48 monorepo/fullstack configs; express and fastify fullstack each install, build, typecheck, and pass their tests (real integration run); the web command round-trips through the CLI to a fullstack Express project. Added both to the integration matrix and the version-catalog conformance matrix. Closes #29 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29: the
fullstackpreset always scaffolded Hono, ignoring--server/serviceFramework. A documented override looked broken from the CLI, MCP, and web configurator.Generation
apps/serveris now generated per framework, each serving/api/health(the sharedHealthshape) and, in production, the built web app fromapps/web/dist:@hono/node-serverserveStatic (default; byte-identical to before)express.static+ supertest tests;apptyped asExpressto satisfy the workspace's declaration emit (TS2742 fix)@fastify/static(added to the version catalog) +injecttestsThe other half of the bug — surfacing it
Even with generation fixed, no surface let you pick the framework for fullstack, because
serviceFramework'swhenonly triggered on aservicetarget (fullstack's target islibrary). Fixed:serviceFramework'swhenand the CLI wizard now trigger for the fullstack layout too, so the picker appears--serverfor fullstack — and--monorepo-layout, a pre-existing gap that made the fullstack command unreproducible since 2.9Verified
@fastify/staticpath and the Express supertest path both work.--framework react --server express --monorepo --monorepo-layout fullstack).fullstack --server expressandfullstack --server fastifyto the integration matrix, and fullstack framework variants to the version-catalog conformance matrix.99 tests pass, lint clean.
Closes #29
🤖 Generated with Claude Code