chore: declare the Node floor we actually test + clarify upgrade docs - #39
Merged
Conversation
Packkit's own package.json (root and mcp) declared engines node >=18, but CI only exercises Node 20, 22, and 24 — an untested, EOL floor that any provider package would inherit through a peerDependency range. Raise both to >=20 so the declared floor matches what we test. (Generated projects keep their deliberate Node 24 floor; the react/react-dom >=18 peer ranges are unrelated.) Also reorder the README upgrade section so the flow reads new-projects-first: baseline-aware for 3.3+ projects, conservative fallback for older ones, and an explicit note that --apply never overwrites your edits or resolves conflicts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for provider work — two honesty fixes flagged in the 3.3 architecture review.
Node floor
Root and
mcp/package.jsondeclaredengines.node: ">=18", but CI only runs Node 20, 22, 24. That's an untested (and now EOL) floor — and a future@packkit/provider-*package would inherit it verbatim through apeerDependencies: { "create-packkit": "^3.x" }range. Raised both to>=20to match reality.Left alone deliberately:
DEFAULT_NODE);react/react-dom>=18peer ranges — that's React 18+, unrelated to Node.README
Reordered the upgrade section to read new-projects-first: baseline-aware for 3.3+ projects, conservative fallback for older ones, plus an explicit line that
--applynever overwrites your edits or resolves conflicts for you.No code changes; 112 tests pass, lint clean.
🤖 Generated with Claude Code