Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134)#165
Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134)#165
Conversation
* Bump next from 15.5.7 to 15.5.9 (0xsequence#944) Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.7...v15.5.9) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Pin foundry to v1.5.0 instead of nightly (0xsequence#947) * Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945) * Include repo and extras in syncpack config to ensure deps are synced across all * Updating support deps * Updating deps * Updating pnpm lock * Fixing type errors within wdk tests * Short circuit 404s (0xsequence#949) * skip witness on signers that don't support it * add passkey to test * 3.0.0-beta.6 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: Corban Riley <corbanbrook@gmail.com> Co-authored-by: Agusx1211 <agusgit@pm.me>
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the Wallet Development Kit (WDK) by optimizing signer identification logic, particularly for non-witnessable signers, which helps prevent 404 errors and streamlines operations. It also includes a comprehensive update of various project dependencies to their latest versions, enhancing stability and leveraging new features. Furthermore, the monorepo's dependency management is improved by extending Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on dependency updates across the monorepo, including bumping versions for numerous @0xsequence packages to 3.0.0-beta.6 and @repo packages to 0.0.1-beta.1, along with updating various development dependencies like next, react, eslint, typescript, vitest, and happy-dom. The syncpack configuration was extended to cover extras and repo directories. Functionally, the changes introduce a nonWitnessableSigners option to the ManagerOptions in @0xsequence/wallet-wdk, allowing certain signers (like passkeys and static guard topology leaves) to bypass witness probing, which addresses a 'signer 404 error' and includes minor fixes. Review comments highlighted the use of non-null assertion operators (!) in test code, advising caution and suggesting explicit checks or stricter mocking for production code, and also pointed out instances where as any was used, recommending more specific type definitions for improved type safety.
Dargon789
left a comment
Dargon789
left a comment
There was a problem hiding this comment.
Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134)#165
merge to master
Dargon789
added
documentation
Pull request was closed
Dargon789
deleted the
foundry-v1.5.0-instead-of-nightly-(0xsequence#947)-(#134)
branch
Dargon789
restored the
foundry-v1.5.0-instead-of-nightly-(0xsequence#947)-(#134)
branch
1 participant
Bumps next from 15.5.7 to 15.5.9.
updated-dependencies:
Pin foundry to v1.5.0 instead of nightly (Pin foundry to v1.5.0 instead of nightly 0xsequence/sequence.js#947)
Include repo and extras in syncpack config to ensure deps are synced (Include repo and extras in syncpack config to ensure deps are synced 0xsequence/sequence.js#945)
Include repo and extras in syncpack config to ensure deps are synced across all
Updating support deps
Updating deps
Updating pnpm lock
Fixing type errors within wdk tests
Short circuit 404s (Short circuit 404s 0xsequence/sequence.js#949)
skip witness on signers that don't support it
add passkey to test
3.0.0-beta.6