Skip to content

Comments

Revert 681 update constants (#18)#19

Merged
Dargon789 merged 2 commits intomasterfrom
main
Mar 13, 2025
Merged

Revert 681 update constants (#18)#19
Dargon789 merged 2 commits intomasterfrom
main

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Mar 13, 2025

This reverts commit a181b69.

  • [AUTOMATED] Update files from 0xsequence/stack ([AUTOMATED] Update files from 0xsequence/stack 0xsequence/sequence.js#680)

  • [AUTOMATED] Update: api/proto/clients/api.gen.ts

  • [AUTOMATED] Update: api/proto/clients/api.gen.ts

  • [AUTOMATED] Update: api/proto/clients/api.gen.ts

  • [AUTOMATED] Update: api/proto/clients/api.gen.ts

  • [AUTOMATED] Update: api/proto/clients/api.gen.ts




Summary by Sourcery

Reverts the changes introduced by commit a181b69, effectively undoing the updates to constants and generated client files.

* Revert "[AUTOMATED] Update constants.ts (0xsequence#681)"

This reverts commit a181b69.

* [AUTOMATED] Update files from 0xsequence/stack (0xsequence#680)

* [AUTOMATED] Update: api/proto/clients/api.gen.ts

* [AUTOMATED] Update: api/proto/clients/api.gen.ts

* [AUTOMATED] Update: api/proto/clients/api.gen.ts

* [AUTOMATED] Update: api/proto/clients/api.gen.ts

* [AUTOMATED] Update: api/proto/clients/api.gen.ts

---------

Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com>
Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com>

* [AUTOMATED] Update files from 0xsequence/marketplace-api (0xsequence#682)

* [AUTOMATED] Update: proto/clients/marketplace.gen.ts

* [AUTOMATED] Update: proto/clients/marketplace.gen.ts

* [AUTOMATED] Update: proto/clients/marketplace.gen.ts

* [AUTOMATED] Update: proto/clients/marketplace.gen.ts

* [AUTOMATED] Update: proto/clients/marketplace.gen.ts

---------

Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com>

* [AUTOMATED] Update: proto/clients/metadata.gen.ts (0xsequence#684)

Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>

* [AUTOMATED] Update: proto/clients/relayer.gen.ts (0xsequence#685)

Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>

* [AUTOMATED] Update: proto/clients/guard.gen.ts (0xsequence#686)

Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>

* feat: auto prefix message with EIP191 if not prefixed (0xsequence#689)

* feat: add auto prefixing check to account.signMessage

* refactor: refactor logic to use ethers method

* [AUTOMATED] Update: api/proto/clients/api.gen.ts (0xsequence#690)

Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com>

---------

Co-authored-by: 0xsequence-bot <50996415+0xsequence-bot@users.noreply.github.com>
Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com>
Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com>
Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com>
Co-authored-by: Gabi <56271768+VGabriel45@users.noreply.github.com>
Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Mar 13, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 13, 2025

Reviewer's Guide by Sourcery

This pull request reverts commit a181b69, which includes changes such as updating webrpc-gen versions, modifying message hashing in tests, removing MONAD and SOMNIA testnet constants, and adding logic for auto-prefixing messages with EIP191.

Reverted ER Diagram for ChainId Enum

erDiagram
    ChainId ||--o{ NetworkMetadata : has
    ChainId {
      MOONBEAM int
      MOONBASE_ALPHA int
    }
    NetworkMetadata {
      ChainId int
    }
    note for ChainId "MONAD_TESTNET and SOMNIA_TESTNET removed"
Loading

Reverted Class Diagram for Account

classDiagram
  class Account {
    -signerOptions: AccountSignerOptions
    +signMessage(message: ethers.BytesLike, chainId: ethers.BigNumberish, cantValidateBehavior: 'ignore' | 'eip6492' | 'throw'): Promise<string>
  }
  note for Account "signMessage now prefixes messages with EIP191 if not already prefixed"
  class AccountSigner {
    +signMessage(message: string | ethers.BytesLike): Promise<string>
  }
  note for AccountSigner "signMessage now uses the updated signMessage method from Account"
Loading

File-Level Changes

Change Details Files
Reverts the update of webrpc-gen and typescript generator versions in api.gen.ts.
  • Reverts the webrpc-gen version from v0.23.2 to v0.22.0.
  • Reverts the typescript generator version from v0.16.3 to v0.16.1.
  • Reverts the WebRPCHeaderValue constant.
  • Reverts the WebRPCSchemaHash constant.
packages/api/src/api.gen.ts
Reverts the update of webrpc-gen and typescript generator versions in marketplace.gen.ts.
  • Reverts the webrpc-gen version from v0.23.2 to v0.21.1.
  • Reverts the typescript generator version from v0.16.3 to v0.15.1.
  • Reverts the WebRPCHeaderValue constant.
  • Reverts the WebRPCSchemaHash constant.
packages/marketplace/src/marketplace.gen.ts
Reverts the update of webrpc-gen and typescript generator versions in metadata.gen.ts.
  • Reverts the webrpc-gen version from v0.23.2 to v0.21.1.
  • Reverts the typescript generator version from v0.16.3 to v0.15.1.
  • Reverts the WebRPCHeaderValue constant.
packages/metadata/src/metadata.gen.ts
Reverts the update of webrpc-gen and typescript generator versions in relayer.gen.ts.
  • Reverts the webrpc-gen version from v0.23.2 to v0.22.0.
  • Reverts the typescript generator version from v0.16.3 to v0.16.1.
  • Reverts the WebRPCHeaderValue constant.
packages/relayer/src/rpc-relayer/relayer.gen.ts
Reverts the update of webrpc-gen and typescript generator versions in guard.gen.ts.
  • Reverts the webrpc-gen version from v0.23.2 to v0.22.0.
  • Reverts the typescript generator version from v0.16.3 to v0.16.1.
  • Reverts the WebRPCHeaderValue constant.
packages/guard/src/guard.gen.ts
Reverts the change to use ethers.hashMessage instead of ethers.keccak256 for message hashing in account.spec.ts.
  • Reverts the usage of ethers.hashMessage to ethers.keccak256 in multiple tests.
  • Reverts the usage of ethers.hashMessage to ethers.keccak256 in multiple tests.
packages/account/tests/account.spec.ts
Reverts the removal of constants related to MONAD and SOMNIA testnets.
  • Reintroduces ChainId values for MONAD_TESTNET and SOMNIA_TESTNET.
  • Reintroduces network metadata for MONAD_TESTNET, including chainId, type, name, title, logoURI, testnet status, block explorer information, and native token details.
  • Reintroduces network metadata for SOMNIA_TESTNET, including chainId, type, name, title, logoURI, testnet status, block explorer information, and native token details.
packages/network/src/constants.ts
Reverts the logic to auto-prefix messages with EIP191 if not prefixed in account.ts and account.ts.
  • Removes the conditional logic that checks if the message is already prefixed with EIP-191 before hashing.
  • Removes the addition of a new test case to verify the signing of messages already prefixed with EIP-191.
packages/account/src/account.ts
packages/account/src/signer.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Mar 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@Dargon789 Dargon789 merged commit 31d9b05 into master Mar 13, 2025
10 checks passed
@Dargon789 Dargon789 deleted the main branch March 13, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant