Conversation
* Revert "[AUTOMATED] Update constants.ts (0xsequence#681)" This reverts commit a181b69. * [AUTOMATED] Update files from 0xsequence/stack (0xsequence#680) * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts --------- Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com> * [AUTOMATED] Update files from 0xsequence/marketplace-api (0xsequence#682) * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts --------- Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com> * [AUTOMATED] Update: proto/clients/metadata.gen.ts (0xsequence#684) Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> * [AUTOMATED] Update: proto/clients/relayer.gen.ts (0xsequence#685) Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> * [AUTOMATED] Update: proto/clients/guard.gen.ts (0xsequence#686) Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> * feat: auto prefix message with EIP191 if not prefixed (0xsequence#689) * feat: add auto prefixing check to account.signMessage * refactor: refactor logic to use ethers method * [AUTOMATED] Update: api/proto/clients/api.gen.ts (0xsequence#690) Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com> --------- Co-authored-by: 0xsequence-bot <50996415+0xsequence-bot@users.noreply.github.com> Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: nachopiris <66640666+nachopiris@users.noreply.github.com> Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com> Co-authored-by: david-littlefarmer <17728576+david-littlefarmer@users.noreply.github.com> Co-authored-by: AlexanderKolberg <74478295+AlexanderKolberg@users.noreply.github.com> Co-authored-by: Gabi <56271768+VGabriel45@users.noreply.github.com> Co-authored-by: taylanpince <12650+taylanpince@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
Reviewer's Guide by SourceryThis pull request reverts commit a181b69, which includes changes such as updating webrpc-gen versions, modifying message hashing in tests, removing MONAD and SOMNIA testnet constants, and adding logic for auto-prefixing messages with EIP191. Reverted ER Diagram for ChainId EnumerDiagram
ChainId ||--o{ NetworkMetadata : has
ChainId {
MOONBEAM int
MOONBASE_ALPHA int
}
NetworkMetadata {
ChainId int
}
note for ChainId "MONAD_TESTNET and SOMNIA_TESTNET removed"
Reverted Class Diagram for AccountclassDiagram
class Account {
-signerOptions: AccountSignerOptions
+signMessage(message: ethers.BytesLike, chainId: ethers.BigNumberish, cantValidateBehavior: 'ignore' | 'eip6492' | 'throw'): Promise<string>
}
note for Account "signMessage now prefixes messages with EIP191 if not already prefixed"
class AccountSigner {
+signMessage(message: string | ethers.BytesLike): Promise<string>
}
note for AccountSigner "signMessage now uses the updated signMessage method from Account"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a181b69.
[AUTOMATED] Update files from 0xsequence/stack ([AUTOMATED] Update files from 0xsequence/stack 0xsequence/sequence.js#680)
[AUTOMATED] Update: api/proto/clients/api.gen.ts
[AUTOMATED] Update: api/proto/clients/api.gen.ts
[AUTOMATED] Update: api/proto/clients/api.gen.ts
[AUTOMATED] Update: api/proto/clients/api.gen.ts
[AUTOMATED] Update: api/proto/clients/api.gen.ts
[AUTOMATED] Update files from 0xsequence/marketplace-api ([AUTOMATED] Update files from 0xsequence/marketplace-api 0xsequence/sequence.js#682)
[AUTOMATED] Update: proto/clients/marketplace.gen.ts
[AUTOMATED] Update: proto/clients/marketplace.gen.ts
[AUTOMATED] Update: proto/clients/marketplace.gen.ts
[AUTOMATED] Update: proto/clients/marketplace.gen.ts
[AUTOMATED] Update: proto/clients/marketplace.gen.ts
[AUTOMATED] Update: proto/clients/metadata.gen.ts ([AUTOMATED] Update files from 0xsequence/metadata 0xsequence/sequence.js#684)
[AUTOMATED] Update: proto/clients/relayer.gen.ts ([AUTOMATED] Update files from 0xsequence/relayer 0xsequence/sequence.js#685)
[AUTOMATED] Update: proto/clients/guard.gen.ts ([AUTOMATED] Update files from 0xsequence/guard 0xsequence/sequence.js#686)
feat: auto prefix message with EIP191 if not prefixed (feat: auto prefix message with EIP191 if not prefixed 0xsequence/sequence.js#689)
feat: add auto prefixing check to account.signMessage
refactor: refactor logic to use ethers method
[AUTOMATED] Update: api/proto/clients/api.gen.ts ([AUTOMATED] Update files from 0xsequence/stack 0xsequence/sequence.js#690)
Summary by Sourcery
Reverts the changes introduced by commit a181b69, effectively undoing the updates to constants and generated client files.