Skip to content

Comments

Main v1.10.15#206

Closed
Dargon789 wants to merge 1028 commits intomain.v1.9.17from
main-v1.10.15
Closed

Main v1.10.15#206
Dargon789 wants to merge 1028 commits intomain.v1.9.17from
main-v1.10.15

Conversation

@Dargon789
Copy link
Owner

No description provided.

patrislav and others added 30 commits September 11, 2025 12:39
* guard: return a specific error when auth required

* core: pass guard token to the service

* wdk: handle prompting for guard 2FA code

* dapp-client: handle prompting for guard 2FA code

* guard 2fa tests

* wdk: separate wallet and sessions guards

* dapp-client: remove guard 2fa

* dapp-client: fix imports

* fix guard tests

* wdk: remove unneeded promise resolve
… guardAddresses Map with Record<GuardRole, Address>
Fallback to chain for non-logged in recovery
…-get

Wallet db try checksum and lowercase fetch
Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js).


Updates `next` from 15.4.2 to 15.4.7
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.4.2...v15.4.7)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.4.7
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Improve session validity testing when signing calls
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Jan 17, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

protected path = '/rpc/Builder/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IdentityInstrument/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/Indexer/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/IndexerGateway/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
protected path = '/rpc/UserData/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
This
regular expression
that depends on
library input
may run slow on strings with many repetitions of '/'.
Comment on lines +185 to +191
return template.replace(/{(.*?)}/g, (_, key) => {
const value = values[key]
if (value === undefined) {
throw new Error(`Missing template value for ${template}: ${key}`)
}
return value
})

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '{' and with many repetitions of '{a'.
This
regular expression
that depends on
library input
may run slow on strings starting with '{' and with many repetitions of '{a'.
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 787

@snyk-io
Copy link

snyk-io bot commented Jan 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Dargon789 Dargon789 enabled auto-merge (rebase) January 17, 2026 12:51
Repository owner deleted a comment from vercel bot Jan 17, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive refactoring of the project's foundational architecture and development infrastructure. The primary goal is to modernize the monorepo tooling, streamline CI/CD processes, and modularize the core 'sequence.js' libraries in preparation for a major v3 release. These changes aim to improve development efficiency, enforce code quality, and provide a clearer structure for future enhancements.

Highlights

  • Monorepo Tooling Overhaul: The project's build system has been significantly refactored, transitioning from 'preconstruct' to 'turbo' for enhanced performance and integrating 'lefthook' for streamlined Git hooks and automated code quality checks.
  • CI/CD and Development Environment Enhancements: New configurations for CircleCI and Azure Pipelines have been introduced to automate testing and deployment. Additionally, CodeSandbox and VS Code debugging setups have been added to improve the developer experience.
  • Core Library Restructuring for v3: Multiple legacy '@0xsequence' packages (e.g., '0xsequence', 'abi', 'account', 'api', 'auth', 'core') have been removed, indicating a major modularization and refactoring of the core 'sequence.js' libraries, with a new focus on 'wallet-primitives', 'wallet-core', and 'wallet-wdk' for the upcoming v3 release.
  • Structured Release Process: The 'changeset' configuration has been updated, and new pre-release definitions have been added, establishing a more structured approach to managing beta releases for v3, including specific patch entries for various fixes and beta versions.
  • Improved Project Governance and Documentation: New issue templates, CODEOWNERS, and a completely rewritten README.md have been implemented to enhance project governance, clarify contribution guidelines, and provide up-to-date documentation reflecting the project's new direction.
Ignored Files
  • Ignored by pattern: .github/workflows/** (4)
    • .github/workflows/fortify.yml
    • .github/workflows/on_pr_pnpm-format-label.yml
    • .github/workflows/pnpm-format.yml
    • .github/workflows/tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major refactoring and version upgrade for the project, migrating to a modern monorepo setup with Turborepo and pnpm. It includes a complete overhaul of the package structure, build tooling, CI/CD configurations, and documentation. Numerous old packages have been removed and replaced with a new structure under packages/ and extras/. While the overall direction is excellent, I've found several critical and medium severity issues in the new configuration files for CI/CD and project metadata that need to be addressed to ensure the new setup works correctly and securely.

@Dargon789 Dargon789 linked an issue Jan 18, 2026 that may be closed by this pull request
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 19, 2026 7:23am
sequence-js-web Ready Ready Preview, Comment Jan 19, 2026 7:23am

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

# Class diagram for new explicit session config utilities

8 participants