Conversation
* guard: return a specific error when auth required * core: pass guard token to the service * wdk: handle prompting for guard 2FA code * dapp-client: handle prompting for guard 2FA code * guard 2fa tests * wdk: separate wallet and sessions guards * dapp-client: remove guard 2fa * dapp-client: fix imports * fix guard tests * wdk: remove unneeded promise resolve
Add RC3 contracts
Add standalone fetch queued payloads
… guardAddresses Map with Record<GuardRole, Address>
Fallback to chain for non-logged in recovery
…-get Wallet db try checksum and lowercase fetch
Bumps the npm_and_yarn group with 1 update in the / directory: [next](https://github.com/vercel/next.js). Updates `next` from 15.4.2 to 15.4.7 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.4.2...v15.4.7) --- updated-dependencies: - dependency-name: next dependency-version: 15.4.7 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Improve session validity testing when signing calls
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
| protected path = '/rpc/Builder/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| protected path = '/rpc/IdentityInstrument/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| protected path = '/rpc/Indexer/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| protected path = '/rpc/IndexerGateway/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| protected path = '/rpc/UserData/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| return template.replace(/{(.*?)}/g, (_, key) => { | ||
| const value = values[key] | ||
| if (value === undefined) { | ||
| throw new Error(`Missing template value for ${template}: ${key}`) | ||
| } | ||
| return value | ||
| }) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive refactoring of the project's foundational architecture and development infrastructure. The primary goal is to modernize the monorepo tooling, streamline CI/CD processes, and modularize the core 'sequence.js' libraries in preparation for a major v3 release. These changes aim to improve development efficiency, enforce code quality, and provide a clearer structure for future enhancements. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a major refactoring and version upgrade for the project, migrating to a modern monorepo setup with Turborepo and pnpm. It includes a complete overhaul of the package structure, build tooling, CI/CD configurations, and documentation. Numerous old packages have been removed and replaced with a new structure under packages/ and extras/. While the overall direction is excellent, I've found several critical and medium severity issues in the new configuration files for CI/CD and project metadata that need to be addressed to ensure the new setup works correctly and securely.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
No description provided.